Allow overwriting saved search #793
Conversation
…vedSearchCreateDialog.kt
Reviewer's Guide by SourceryThis pull request implements the ability to overwrite existing saved searches. When a user attempts to create a new saved search with a name that already exists, a confirmation dialog will appear, prompting the user to confirm whether they want to overwrite the existing saved search. Sequence diagram for overwriting a saved searchsequenceDiagram
participant User
participant SavedSearchCreateDialog
participant DatabaseHandler
User->>SavedSearchCreateDialog: Clicks 'Create' with existing name
SavedSearchCreateDialog->>DatabaseHandler: getSavedSearchByName(name)
DatabaseHandler-->>SavedSearchCreateDialog: Returns existing saved search
SavedSearchCreateDialog->>User: Shows confirmation dialog
User->>SavedSearchCreateDialog: Confirms overwrite
SavedSearchCreateDialog->>DatabaseHandler: createSavedSearch(name, overwrite = true)
DatabaseHandler-->>SavedSearchCreateDialog: Success
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @Turhvjbufv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request introduces a change to the saved search creation process. Previously, if a user attempted to create a saved search with a name that already existed, the creation would likely fail or overwrite the existing search without warning. Now, the application will display a confirmation dialog asking the user if they want to overwrite the existing saved search. This prevents accidental overwrites and provides a better user experience. The changes are isolated to SavedSearchCreateDialog.kt.
Highlights
- Overwrite Confirmation: The main highlight is the addition of a confirmation dialog when a user tries to create a saved search with a name that already exists. This prevents accidental data loss.
- User Experience Improvement: This change improves the user experience by providing a warning and a choice to the user, rather than silently overwriting their existing saved search.
Changelog
- app/src/main/java/eu/kanade/tachiyomi/ui/browse/savedsearch/SavedSearchCreateDialog.kt
- Modified the
okButton.setOnClickListenerto check for existing saved searches with the same name. - Added a confirmation dialog to ask the user if they want to overwrite the existing saved search if one is found.
- The
createSavedSearchfunction is now called with anoverwriteflag based on the user's choice in the confirmation dialog.
- Modified the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A dialog appears, a question it poses,
"Overwrite the search?" the code discloses.
A choice to be made, a path to pursue,
To keep what is old, or welcome the new.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces a feature to allow users to overwrite existing saved searches when creating a new one with the same name. This enhancement improves the user experience by providing a way to manage saved searches more effectively. The implementation involves adding a confirmation dialog to prompt users before overwriting an existing saved search.
Merge Readiness
The code changes introduce a useful feature for managing saved searches. The implementation appears to be straightforward and addresses the intended functionality. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. There are no critical or high severity issues, so the pull request is likely ready to be merged after addressing the medium severity issue.
| showConfirmationDialog( | ||
| message = "A saved search with this name already exists. Overwrite?", | ||
| onConfirm = { createSavedSearch(name, overwrite = true) }, | ||
| onCancel = { /* Allow user to modify the name */ } |
There was a problem hiding this comment.
Consider providing user feedback or logging when the user cancels the overwrite operation. Currently, the onCancel lambda is empty, which might not be ideal for debugging or user understanding. A simple log message or a toast could be helpful.
onCancel = { Timber.d("Overwrite cancelled by user") }![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Turhvjbufv - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the logic for checking existing saved searches and prompting for overwrite into a separate function for better readability.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| val name = nameInput.text.toString().trim() | ||
| databaseHandler.getSavedSearchByName(name) { existing -> | ||
| if (existing != null) { |
There was a problem hiding this comment.
suggestion: Consider validating non-empty input.
After trimming, an empty string might be passed into the search creation logic. It might be beneficial to check that 'name' is not empty and to provide early feedback to the user if it is.
| val name = nameInput.text.toString().trim() | |
| databaseHandler.getSavedSearchByName(name) { existing -> | |
| if (existing != null) { | |
| val name = nameInput.text.toString().trim() | |
| if (name.isEmpty()) { | |
| Toast.makeText(context, "Name cannot be empty", Toast.LENGTH_SHORT).show() | |
| return@setOnClickListener | |
| } | |
| databaseHandler.getSavedSearchByName(name) { existing -> | |
| if (existing != null) { |
Now when trying to create a new saved search and a saved search with the same name already exists it will ask the user if they want to override it
Done with gitauto ai, Screenshot and testing were not done as discussed with the main dev
Summary by Sourcery
Enhancements: