dont queue up presence detections #2022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
changed the title
RebeccaMahany
previously approved these changes
Jan 2, 2025
James-Pickett
commented
Jan 2, 2025
| // using try lock here because we don't want presence detections to queue up, | ||
| // in the event that the users presses cancel, if the request were queued up, it would | ||
| // request the presence detection again | ||
| if !pd.mutex.TryLock() { |
There was a problem hiding this comment.
actually, this seems racy, may need 2 mutexes here, one for the lastDetection value and one for actually prompting the user then just try lock the actual prompting
RebeccaMahany
approved these changes
Jan 2, 2025
|
not working as expected, will reopen after some tweaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.