Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status message when nvtx connectors are not built #280

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add status message when nvtx connectors are not built #280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8db3a27
Add status message when nvtx connectors are not built
cwpearson Jan 16, 2025
356bb4a
Add status message when roctx-connector is not built
cwpearson Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,17 @@ if(KOKKOSTOOLS_HAS_VARIORUM)
endif()

# GPU profilers
if(Kokkos_ENABLE_CUDA)
if(KOKKOSTOOLS_HAS_NVTX)
add_subdirectory(profiling/nvtx-connector)
add_subdirectory(profiling/nvtx-focused-connector)
else()
message(STATUS "Skipping nvtx-connector: NVTX is not enabled (maybe Kokkos was not found, or not configured with the CUDA backend)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like that the message is potentially confusing, I would do just

Suggested change
message(STATUS "Skipping nvtx-connector: NVTX is not enabled (maybe Kokkos was not found, or not configured with the CUDA backend)")
message(STATUS "Skipping nvtx-connector (NVTX disabled)")

message(STATUS "Skipping nvtx-focused-connector: NVTX is not enabled (maybe Kokkos was not found, or not configured with the CUDA backend)")
dalg24 marked this conversation as resolved.
Show resolved Hide resolved
endif()
if(Kokkos_ENABLE_HIP)
if(KOKKOSTOOLS_HAS_ROCTX)
add_subdirectory(profiling/roctx-connector)
else()
message(STATUS "Skipping roctx-connector: ROCTX is not enabled (maybe Kokkos was not found, or not configured with the HIP backend)")
endif()

if(KOKKOSTOOLS_HAS_VTUNE)
Expand Down
Loading