kp_kernel_logger.cpp: typo in end scan call back function #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end callback for scan in kp_kernel_logger.cpp has a typo in the function. This never broke kernel logger and didn't not cause a problem unless one used parallel_scan in their code. This causes a parent tool or tool utility to not recognize that this end callback exists when the tool utility or parent tool checks that its child library function call exists. This impacts the sampler utility and can also impact the kernel filter utility.
In any case, this one character edit to the code file needs to be fixed as soon as possible so that Kokkos user using Kokkos Tools kernel logger sees prints of parallel_scan in their kernel_logger output.
This is part of the original PR #213 but I am breaking that one down into small changes since there are a sizeable number and this impacts more than just the sampler.