Skip to content
This repository was archived by the owner on Apr 21, 2026. It is now read-only.

Always parse query string, on the main request or on sub-requests - #693

Merged
enov merged 3 commits into
3.3/developfrom
3.3/bugfix/always-parse-get
Jul 25, 2016
Merged

enov merged 3 commits into
3.3/developfrom
3.3/bugfix/always-parse-get

Conversation

@enov

@enov enov commented Jul 21, 2016

Copy link
Copy Markdown
Contributor

Initial request will have the global $_GET re-applied in the factory()
method.

Related to #627 (comment)

cc @hkdobrev

@acoulton could you please advise how to add a test case for this.

Initial request will have the global $_GET re-applied in the `factory()`
method.
@hkdobrev

Copy link
Copy Markdown
Contributor

Thanks for the swift fix! It looks good to me! I could probably try to work on a test for that a bit later today and if I succeed will PR your branch.

@hkdobrev

Copy link
Copy Markdown
Contributor

@enov I've added a test for your changes in #694

Test query params are parsed correctly in both initial and subrequests
@acoulton

Copy link
Copy Markdown
Member

@hkdobrev @enov thanks for this, looks good to me. @enov I'll let you double-check you're happy with the test case, if so go ahead and merge this.

@enov
enov merged commit 277f6d7 into 3.3/develop Jul 25, 2016
@enov

enov commented Jul 25, 2016

Copy link
Copy Markdown
Contributor Author

Thank you @hkdobrev, @acoulton. I reviewed the test case and it's good. I also run the test without the patch and it's failing as expected. Keep up the good work @hkdobrev!

@enov
enov deleted the 3.3/bugfix/always-parse-get branch July 25, 2016 07:48
@hkdobrev

Copy link
Copy Markdown
Contributor

@enov @acoulton Do you think this could be released as 3.3.6 or something like that? I'm not sure why you need to keep versions of core modules synchronised with core.

@enov

enov commented Jul 25, 2016

Copy link
Copy Markdown
Contributor Author

@acoulton @hkdobrev 3.3.6 is released, please test and let me know if I missed anything.

cc @rjd22 @neo22s

@neo22s

neo22s commented Jul 25, 2016 •

Copy link
Copy Markdown
Member

hello,

Thanks to all, what are the main differences with 3.3.5? EDIT here it is sorry xD https://github.com/kohana/kohana/releases

I will test later, regards

@acoulton

Copy link
Copy Markdown
Member

Thanks @enov

@neo22s

neo22s commented Jul 26, 2016 •

Copy link
Copy Markdown
Member

@enov the release is missing, the packed version with the core in it I mean.

Also the modules, I have used the ones packed for 3.3.5.

I have updated the release and added the ZIP file. I hope I have done this correctly.

@neo22s

neo22s commented Jul 26, 2016

Copy link
Copy Markdown
Member

ok,have tested and all seems ok ;)

@enov

enov commented Aug 2, 2016

Copy link
Copy Markdown
Contributor Author

I have updated the release and added the ZIP file.

Thanks @neo22s

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants