This repository was archived by the owner on Apr 21, 2026. It is now read-only.
Repository navigation
Always parse query string, on the main request or on sub-requests - #693
Merged
Merged
Conversation
Initial request will have the global $_GET re-applied in the `factory()` method.
Contributor
|
Thanks for the swift fix! It looks good to me! I could probably try to work on a test for that a bit later today and if I succeed will PR your branch. |
Contributor
Test query params are parsed correctly in both initial and subrequests
Member
Contributor
Author
Contributor
Member
|
hello, Thanks to all, what are the main differences with 3.3.5? EDIT here it is sorry xD https://github.com/kohana/kohana/releases I will test later, regards |
Member
|
Thanks @enov |
Member
|
@enov the release is missing, the packed version with the core in it I mean. Also the modules, I have used the ones packed for 3.3.5. I have updated the release and added the ZIP file. I hope I have done this correctly. |
Member
|
ok,have tested and all seems ok ;) |
Contributor
Author
Thanks @neo22s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial request will have the global $_GET re-applied in the
factory()method.
Related to #627 (comment)
cc @hkdobrev
@acoulton could you please advise how to add a test case for this.