Create new method Kohana::init_modules() #530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the module initialisation functionality from Kohana::modules() and places it into its own method called Kohana::init_modules().
Previous PRs to the 3.4/develop branch has forced Kohana::modules() to be called in the bootstrap before any classes are used. This causes a problem because a few things need to be done before the modules are initialised such as attaching a config object to Kohana::$config (the userguide uses this for example https://github.com/kohana/userguide/blob/3.3/master/init.php#L12).
To fix this problem, the method Kohana::init_modules() can be called after everything has been set up for init files in the bootstrap.