-
-
Notifications
You must be signed in to change notification settings - Fork 117
Adding Format impl for core::num::Wrapping #983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for this. The PR looks fine, but there's a CI failure. I think this is not due to your change but due to a change in what Rust is doing. Let me open an issue for that. |
|
Let's get #999 in and then rebase this on main. Apologies for the delay. |
|
@jonathanpallant it looks like the pull request you mentioned was merged in. What are next steps to get this pull request moving?
Do you need anything from me? |
|
#1009 should fix the CI failure. |
|
@jmriesen I'd be happy to merge this directly if you have time to solve the minor issue, else I can make a fixup and get this merged. Thank you so much for your contribution! |
Issue:#982