Skip to content

Conversation

@jmriesen
Copy link
Contributor

Issue:#982

@jonathanpallant
Copy link
Contributor

Thank you for this. The PR looks fine, but there's a CI failure. I think this is not due to your change but due to a change in what Rust is doing. Let me open an issue for that.

@jonathanpallant
Copy link
Contributor

Let's get #999 in and then rebase this on main. Apologies for the delay.

@jmriesen
Copy link
Contributor Author

jmriesen commented Nov 4, 2025

@jonathanpallant it looks like the pull request you mentioned was merged in.

What are next steps to get this pull request moving?
It looks like this branch

  • needs to be rebased on main
  • Reviewed by someone
  • merged into main.

Do you need anything from me?
It seems to me that it would make the most since for those 3 steps to be done at the same time by the same person.

@jonathanpallant
Copy link
Contributor

#1009 should fix the CI failure.

@Hoverbear
Copy link
Member

@jmriesen I'd be happy to merge this directly if you have time to solve the minor issue, else I can make a fixup and get this merged. Thank you so much for your contribution!

@jmriesen jmriesen requested a review from Hoverbear November 7, 2025 15:12
@jonathanpallant jonathanpallant added this pull request to the merge queue Nov 7, 2025
Merged via the queue into knurling-rs:main with commit ce8c280 Nov 7, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants