Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[binance] Add tickers #4866

Merged
merged 16 commits into from
May 21, 2024
Merged

[binance] Add tickers #4866

merged 16 commits into from
May 21, 2024

Conversation

bigscoop
Copy link
Contributor

@bigscoop bigscoop commented Apr 29, 2024

  • Added mapping symbol -> currency pair (got from exchange info)
  • Moved exchangeInfo-methods to MarketDataService
  • Updated integration tests
  • Added requests for idea http client
  • Simplified dto's

@rizer1980
Copy link
Contributor

Hi.
Two requests for tickers:
api/v3/ticker/price - Latest price for a symbol or symbols.
api/v3/ticker/bookTicker - Best price/qty on the order book for a symbol or symbols.
But there is no volume and quoteVolume and ticker time is only last moment.

If I understand correctly, we should get a 24 hour ticker.
this api is fit:
https://binance-docs.github.io/apidocs/spot/en/#24hr-ticker-price-change-statistics

@bigscoop
Copy link
Contributor Author

bigscoop commented May 4, 2024

Hi. Two requests for tickers: api/v3/ticker/price - Latest price for a symbol or symbols. api/v3/ticker/bookTicker - Best price/qty on the order book for a symbol or symbols. But there is no volume and quoteVolume and ticker time is only last moment.

If I understand correctly, we should get a 24 hour ticker. this api is fit: https://binance-docs.github.io/apidocs/spot/en/#24hr-ticker-price-change-statistics

Hi. Yep, good idea 👍
will change the implementation

@rizer1980
Copy link
Contributor

done
#4868

@bigscoop
Copy link
Contributor Author

bigscoop commented May 4, 2024

@timmolter

I propose to review and merge the #4868 first. Then I can integrate the changes to my branch

@timmolter
Copy link
Member

merged 4868

@bigscoop bigscoop marked this pull request as draft May 10, 2024 09:06
@bigscoop bigscoop marked this pull request as ready for review May 10, 2024 11:26
@bigscoop
Copy link
Contributor Author

merged 4868

done, feel free to review

@bigscoop
Copy link
Contributor Author

@timmolter ping

@timmolter timmolter merged commit ae208df into knowm:develop May 21, 2024
1 check passed
@bigscoop bigscoop deleted the binance-tickers branch May 21, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants