Merge pull request #4860 from bigscoop/binance-test-fixes

[binance] Test fixes
knowm · Apr 29, 2024 · 6396c11 · 6396c11
2 parents ec1e37b + 87d6839
commit 6396c11
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 17 deletions.
diff --git a/xchange-binance/src/test/java/org/knowm/xchange/binance/BinanceAdaptersTest.java b/xchange-binance/src/test/java/org/knowm/xchange/binance/BinanceAdaptersTest.java
@@ -34,7 +34,7 @@ public void testFilledMarketOrder() throws IOException {
         .contains(BinanceOrderFlags.withClientId("gzcLIkn86ag3FycOCEl6Vi"));
 
     MarketOrder copy = ObjectMapperHelper.viaJSON(marketOrder);
-    assertThat(copy).isEqualToComparingFieldByField(marketOrder);
+    assertThat(copy).usingRecursiveComparison().isEqualTo(marketOrder);
   }
 
   @Test

diff --git a/xchange-binance/src/test/java/org/knowm/xchange/binance/ExchangeMetaDataIntegration.java b/xchange-binance/src/test/java/org/knowm/xchange/binance/ExchangeMetaDataIntegration.java
@@ -5,7 +5,6 @@
 import org.junit.BeforeClass;
 import org.junit.Test;
 import org.knowm.xchange.currency.CurrencyPair;
-import org.knowm.xchange.derivative.FuturesContract;
 import org.knowm.xchange.dto.meta.ExchangeMetaData;
 import org.knowm.xchange.dto.meta.InstrumentMetaData;
 
@@ -22,7 +21,7 @@ public static void fetchMetaData() throws Exception {
   @Test
   public void testEthBtcPairMetaData() {
     InstrumentMetaData pairMetaData = metaData.getInstruments().get(CurrencyPair.ETH_BTC);
-    assertThat(pairMetaData.getPriceScale()).isEqualByComparingTo(6);
+    assertThat(pairMetaData.getPriceScale()).isEqualByComparingTo(5);
     assertThat(pairMetaData.getMinimumAmount()).isEqualByComparingTo("0.0001");
     assertThat(pairMetaData.getMaximumAmount().longValueExact()).isEqualTo(100000);
     assertThat(pairMetaData.getAmountStepSize()).isEqualByComparingTo("0.0001");
@@ -37,13 +36,4 @@ public void testLtcBtcPairMetaData() {
     assertThat(pairMetaData.getAmountStepSize()).isEqualByComparingTo("0.001");
   }
 
-  @Test
-  public void testBtcUsdtPerpetualPairMetaData() {
-    InstrumentMetaData pairMetaData =
-        metaData.getInstruments().get(new FuturesContract("BTC/USDT/PERP"));
-    assertThat(pairMetaData.getPriceScale()).isEqualByComparingTo(1);
-    assertThat(pairMetaData.getMinimumAmount()).isEqualByComparingTo("0.001");
-    assertThat(pairMetaData.getVolumeScale()).isEqualTo(3);
-    assertThat(pairMetaData.getAmountStepSize()).isEqualByComparingTo("0.001");
-  }
 }
diff --git a/xchange-binance/src/test/java/org/knowm/xchange/binance/us/ExchangeMetaDataIntegration.java b/xchange-binance/src/test/java/org/knowm/xchange/binance/us/ExchangeMetaDataIntegration.java
@@ -21,18 +21,18 @@ public static void fetchMetaData() throws Exception {
   @Test
   public void testEthBtcPairMetaData() {
     InstrumentMetaData pairMetaData = metaData.getInstruments().get(CurrencyPair.ETH_BTC);
-    assertThat(pairMetaData.getPriceScale()).isEqualByComparingTo(6);
-    assertThat(pairMetaData.getMinimumAmount()).isEqualByComparingTo("0.001");
+    assertThat(pairMetaData.getPriceScale()).isEqualByComparingTo(5);
+    assertThat(pairMetaData.getMinimumAmount()).isEqualByComparingTo("0.0001");
     assertThat(pairMetaData.getMaximumAmount().longValueExact()).isEqualTo(100000);
-    assertThat(pairMetaData.getAmountStepSize()).isEqualByComparingTo("0.001");
+    assertThat(pairMetaData.getAmountStepSize()).isEqualByComparingTo("0.0001");
   }
 
   @Test
   public void testLtcBtcPairMetaData() {
     InstrumentMetaData pairMetaData = metaData.getInstruments().get(new CurrencyPair("LTC/BTC"));
     assertThat(pairMetaData.getPriceScale()).isEqualByComparingTo(6);
-    assertThat(pairMetaData.getMinimumAmount()).isEqualByComparingTo("0.01");
+    assertThat(pairMetaData.getMinimumAmount()).isEqualByComparingTo("0.001");
     assertThat(pairMetaData.getMaximumAmount().longValueExact()).isEqualTo(100000);
-    assertThat(pairMetaData.getAmountStepSize()).isEqualByComparingTo("0.01");
+    assertThat(pairMetaData.getAmountStepSize()).isEqualByComparingTo("0.001");
   }
 }