Please add publish(topic,payload,retained) function. by vrdust · Pull Request #917 · knolleary/pubsubclient

vrdust · 2021-12-28T10:15:09Z

…ectly as an Arduino library

…ack type, rename some arguments

Use WiFiClient instead of Client. Use IPAddress instead of a byte array.

…parameters Why pass in "client"? Just make it a class variable.

willRetain is a boolean and willQos can only be 0, 1, or 2.

…hods by using default values and setters

Move code into the src directory. Add a library.properties file. Specs: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification

…ubSubClient This feels a little like I've reimplmented PubSubClient. I wanted to support more options for the various messages and that meant creating a separate class just for message data. Then to handle the different options for the different messages, I had to create a class for each message type. Streaming functionality is currently not implemented. It is commented out for now.

At one point I had private variables for things that are stored in '_flags'.

As a side effect, it increments the value. Hopefully that's obvious from the name.

Storing Strings in an array appears to be a bad idea.

Assume that next_packet_id() did that already. Improve logic of next_packet_id() to avoid id 0.

Update examples

… the "end" The reserve() method doesn't change the "length" of the string. So all is left is the += operator (or concat() method).

Prints the topic and payload of every message it receives.

…instead of the MQTT_KEEPALIVE define MQTT_KEEPALIVE is the default value.

…rning false, instead of having a big 'if' block around almost everything

…llow compilation outside of the Arduino env

…of strcmp

…brary has no such define And sizes are 32-bit now. TODO: Will have to construct the 'publish' packets with the correct size when this max size is greater than 127 bytes.

…no.h

MQTT packets can be up to 24MB in size.

…mic memory

MQTT/4 instead of MQIsdp/3

…tead of a bool

…ffer

…e packet in Client's buffer Not tested!

A better way to encapsulate the state variables. Still untested!

…g length byte(s) This allows us to parse the small, simple packets e.g connack, ping, etc. They're only four bytes, smaller than the five byte minimum in _read_header(). _read_length() is reenterable, able to shift a single available byte and continue later.

…e message It returns nullptr instead of false.

…s for a response The second one returns a message pointer of the message that came back, thanks to _wait_for().

CONNACK doesn't necessarily mean the connection was successful.

…ailable

Home Assistant did not like having a null byte after the JSON.

…ffecting device sleep state is used

added setTimeGetter function to support time handling when millis() a…

Imroy added 30 commits April 23, 2015 10:20

Move everything under PubSubClient into the root so it can server dir…

5c69907

…ectly as an Arduino library

Add .gitignore file with some (X)Emacs patterns

4f1e53c

Start cleaning up code - this-> is unnecessary, use typedef for callb…

ed8a9ff

…ack type, rename some arguments

Port to ESP8266WiFi library, some more renaming

9fb9e07

Use WiFiClient instead of Client. Use IPAddress instead of a byte array.

Simplify constructors - use setters for optional callback and stream …

8af8d64

…parameters Why pass in "client"? Just make it a class variable.

Update README

ca1e5be

Clean up argument types for connect()

3f46451

willRetain is a boolean and willQos can only be 0, 1, or 2.

Use memcpy instead of loops

68c68e4

Clean up some odd bits of logic and inefficient maths

7398198

Use OR when combining two bytes, instead of addition

6462d59

Use Arduino String class instead of char*, cut down on overloaded met…

64c7cbc

…hods by using default values and setters

Use standard 'bool' type instead of Arduino's 'boolean' type

0396dd5

Always initialise the serial console to 115.2 kbaud in examples

a65ed4e

Make layout more compliant with the Arduino 1.5+ specs

43d0d3d

Move code into the src directory. Add a library.properties file. Specs: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification

Update example sketches with change to the callback signature

94708bc

Update the authentication example using an MQTT::Connect object directly

717ee6a

Oops, the PublishRec/Rel/Comp messages do have a variable header

047b7e8

Oops, some confusion as to where the qos value is stored

51ed30b

At one point I had private variables for things that are stored in '_flags'.

Add getter to PubSubClient for its next packet id

38384bc

As a side effect, it increments the value. Hopefully that's obvious from the name.

Add an example showing how to set the QoS value of a message to publish

84736d2

Have Subscribe and Unsubscribe contstruct a buffer as they go

3c16701

Storing Strings in an array appears to be a bad idea.

Don't increment nextMsgId in the methods that take an MQTT object

f4a77b5

Assume that next_packet_id() did that already. Improve logic of next_packet_id() to avoid id 0.

Change callback signature to simply take an MQTT::Publish object

cd2a4bb

Update examples

Can't use the String array operator to set arbitrary characters after…

47b17a7

… the "end" The reserve() method doesn't change the "length" of the string. So all is left is the += operator (or concat() method).

Add simple subscriber example

d9edf64

Prints the topic and payload of every message it receives.

Fix signature of callback function in subscriber example

70c41f7

Have PubSubClient keep the keepalive value from a connection, use it …

ca78dfd

…instead of the MQTT_KEEPALIVE define MQTT_KEEPALIVE is the default value.

Standardise on checking connected() at the start of a method and retu…

854bc4a

…rning false, instead of having a big 'if' block around almost everything

Use next_packet_id() instead of manipulating nextMsgId directly

9e63964

Imroy and others added 30 commits May 17, 2017 20:15

Tests: define 'String' in Arduino.h and include that in MQTT.cpp to a…

ea3fca5

…llow compilation outside of the Arduino env

Tests: topic is now a String type so use the equals operator instead …

b05e3e7

…of strcmp

Tests: include stddef.h in Client.h to get basic typedefs

889a29d

Tests: define our own MQTT_MAX_PACKET_SIZE since my version of the li…

a7a281b

…brary has no such define And sizes are 32-bit now. TODO: Will have to construct the 'publish' packets with the correct size when this max size is greater than 127 bytes.

Tests: Pull in more pgmspace.h definitions from the ESP8266 for Ardui…

8530574

…no.h

Tests: Use size_t instead of uint16_t for sizes and related variables

ea84e8c

MQTT packets can be up to 24MB in size.

Tests: Don't write past the end of bigPublish in receive_spec

b16cf1f

Tests: Write large packets in receive_spec with multi-byte length field

be57b07

Tests: Add deconstructors to ShimClient and Stream to deallocate dyna…

d14937c

…mic memory

Tests: use proper protocol name and level for MQTT 3.1.1 in connect_spec

e4912c3

MQTT/4 instead of MQIsdp/3

Tests: return the number of bytes available in Buffer.available() ins…

e84fc73

…tead of a bool

Tests: Update Makefile to compile into separate object files first

2349453

Add tests binaries to gitignore file

d599174

Tests: Use std::string in the Buffer class instead of a fixed size bu…

4c04908

…ffer

Make readPacket() state based so it can handle not having the complet…

e0c0e86

…e packet in Client's buffer Not tested!

Move packet parser into a class

a2fae93

A better way to encapsulate the state variables. Still untested!

Use an enum class for parser state variable

9d391d6

Return a message pointer from _wait_for so we can examine the respons…

f37122d

…e message It returns nullptr instead of false.

Split _send_message() into one that just sends and a second that wait…

747c441

…s for a response The second one returns a message pointer of the message that came back, thanks to _wait_for().

Test the return code of the CONNACK response to a connection attempt

beb81e3

CONNACK doesn't necessarily mean the connection was successful.

Update ConnectJSON and PublishJSON for v6 of ArduinoJson

9303c1f

Add available() method to PubSubClient for checking if a packet is av…

45888da

…ailable

Correct documentation on loop() method

79c1dc4

Use new/delete instead of malloc/free

0a9a277

Correctly size and allocated the buffer for JSON messages

d911d76

Home Assistant did not like having a null byte after the JSON.

added setTimeGetter function to support time handling when millis() a…

b44a900

…ffecting device sleep state is used

set TimeGetter return time according to millis

30e4114

fix response_type missing return

198cd48

Merge pull request #94 from egzumer/master

cba2687

added setTimeGetter function to support time handling when millis() a…

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Please add publish(topic,payload,retained) function.#917

Please add publish(topic,payload,retained) function.#917
vrdust wants to merge 207 commits intoknolleary:masterfrom
Imroy:master

vrdust commented Dec 28, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

vrdust commented Dec 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

vrdust commented Dec 28, 2021 •

edited

Loading