Updated mqtt_esp8266.ino to use a better source of random#1054
Open
Avamander wants to merge 1 commit intoknolleary:masterfrom
Open
Updated mqtt_esp8266.ino to use a better source of random#1054Avamander wants to merge 1 commit intoknolleary:masterfrom
Avamander wants to merge 1 commit intoknolleary:masterfrom
Conversation
hmueller01
added a commit
to hmueller01/pubsubclient3
that referenced
this pull request
Feb 26, 2025
hmueller01
added a commit
to hmueller01/pubsubclient3
that referenced
this pull request
Feb 27, 2025
* switch to RANDOM_REG32 / esp_random() instead micros() * see knolleary#1054
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no point to use
micros()instead ofRANDOM_REG32on ESP8266, if anything usingmicros()is rather insecure.