Skip to content

Conversation

@hejtful
Copy link
Contributor

@hejtful hejtful commented Oct 30, 2025

  • Add onContextMenuOutside hook from knime-ui
  • Add contextmenu emits to MenuItems and BaseMenuItems
  • Toggle context menu on options button clicks
  • Close context menu on right-click outside
  • Combine shift and flip floating-ui middleware

NXT-4175 (Layout rework)

@hejtful hejtful requested a review from hriverahdez October 30, 2025 14:11
@hejtful hejtful requested a review from a team as a code owner October 30, 2025 14:11
Copilot AI review requested due to automatic review settings October 30, 2025 14:12
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

🦋 Changeset detected

Latest commit: 855f88b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@knime/components Minor
@knime/hub-features Patch
@knime/jsonforms Patch
@knime/rich-text-editor Patch
@knime/ui-extension-renderer Patch
@knime/virtual-tree Patch
demo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the FileExplorer context menu behavior by adding support for right-click outside detection and toggling the context menu when clicking the options button. The key changes implement a new onContextMenuOutside composable to handle right-click events outside a target element (which onClickOutside from vueuse doesn't handle reliably), add context menu event propagation through MenuItems components, and enhance the FileExplorer context menu positioning with the shift middleware.

  • Added onContextMenuOutside composable for reliable right-click outside detection
  • Added item-contextmenu event emission through MenuItem components
  • Enhanced FileExplorer context menu with toggle behavior and improved positioning

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/components/src/composables/onContextMenuOutside.ts New composable that listens for contextmenu events outside a target element
packages/components/src/composables/index.ts Exports the new onContextMenuOutside composable
packages/components/src/components/base/MenuItem/MenuItems.vue Propagates item-contextmenu events through the component hierarchy
packages/components/src/components/base/MenuItem/BaseMenuItems.vue Adds contextmenu event emission on menu items
packages/components/src/components/FileExplorer/components/FileExplorerContextMenu.vue Implements context menu toggle, right-click outside handling, and adds shift middleware
packages/components/src/components/FileExplorer/components/FileExplorer.vue Adds toggle logic to close context menu when options button is clicked again
.changeset/proud-dragons-march.md Documents the changes for the release notes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hejtful hejtful force-pushed the bug/NXT-4175-file-explorer-context-menu-improvements branch from c75f819 to 7402429 Compare October 30, 2025 15:46
Copilot AI review requested due to automatic review settings October 30, 2025 16:13
@hejtful hejtful force-pushed the bug/NXT-4175-file-explorer-context-menu-improvements branch from 7402429 to b68a536 Compare October 30, 2025 16:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hejtful hejtful force-pushed the bug/NXT-4175-file-explorer-context-menu-improvements branch from b68a536 to 8144691 Compare October 31, 2025 10:22
Copilot AI review requested due to automatic review settings October 31, 2025 12:51
@hejtful hejtful force-pushed the bug/NXT-4175-file-explorer-context-menu-improvements branch from 8144691 to 70755b6 Compare October 31, 2025 12:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hejtful hejtful force-pushed the bug/NXT-4175-file-explorer-context-menu-improvements branch from 70755b6 to d2cca86 Compare October 31, 2025 12:52
Copilot AI review requested due to automatic review settings October 31, 2025 13:27
@hejtful hejtful force-pushed the bug/NXT-4175-file-explorer-context-menu-improvements branch from d2cca86 to 1b339da Compare October 31, 2025 13:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Add onContextMenuOutside hook from knime-ui
- Prevent default contextmenu behavior on BaseMenuItems
- Toggle context menu on options button clicks
- Close context menu on right-click outside
- Combine shift and flip floating-ui middleware

NXT-4175 (Layout rework)
@hejtful hejtful force-pushed the bug/NXT-4175-file-explorer-context-menu-improvements branch from 1b339da to 855f88b Compare October 31, 2025 13:33
@hejtful hejtful merged commit 553eeda into master Oct 31, 2025
5 checks passed
@hejtful hejtful deleted the bug/NXT-4175-file-explorer-context-menu-improvements branch October 31, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants