[wip] Istio now handles prestop hooks correctly so we can drop our workaround #16164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
dprotaso
changed the title
knative-prow
bot
added
the
do-not-merge/work-in-progress
dprotaso
force-pushed
the
drop-exposing-draining-port
branch
from
2f8062e to
b925d6c
Compare
dprotaso
force-pushed
the
drop-exposing-draining-port
branch
from
b925d6c to
08dc2b2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16164 +/- ##
==========================================
- Coverage 80.06% 80.03% -0.03%
==========================================
Files 214 214
Lines 16943 16931 -12
==========================================
- Hits 13565 13551 -14
- Misses 3017 3022 +5
+ Partials 361 358 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #16163
Previously we had a workaround in our serverless service in order to allow our prestop hook to work when Istio Mesh was enabled.
This isn't needed anymore since Istio 1.25 see: istio/istio@0e30509