Skip to content

hack: quote dirname substitution and REPO_ROOT_DIR in release.sh #8992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ankitsinghsisodya wants to merge 2 commits into from
Closed

hack: quote dirname substitution and REPO_ROOT_DIR in release.sh #8992

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b79483b
hack: quote dirname substitution and REPO_ROOT_DIR in release.sh
Ankitsinghsisodya Apr 1, 2026
c3f323f
Update hack/release.sh
Ankitsinghsisodya Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hack/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,11 @@ function build_release() {
# branch since the detail of building may change over time.
local YAML_LIST="$(mktemp)"
export TAG
$(dirname $0)/generate-yamls.sh "${REPO_ROOT_DIR}" "${YAML_LIST}"
"$(dirname "$0")/generate-yamls.sh" "${REPO_ROOT_DIR}" "${YAML_LIST}"
ARTIFACTS_TO_PUBLISH=$(cat "${YAML_LIST}" | tr '\n' ' ')
if (( ! PUBLISH_RELEASE )); then
# Copy the generated YAML files to the repo root dir if not publishing.
cp ${ARTIFACTS_TO_PUBLISH} ${REPO_ROOT_DIR}
cp ${ARTIFACTS_TO_PUBLISH} "${REPO_ROOT_DIR}"
Comment thread
Ankitsinghsisodya marked this conversation as resolved.
Resolved
fi
}

Expand Down
Loading