Repository navigation
hack: quote YAML_OUTPUT_DIR in rm command to prevent word-splitting - #8990
Ankitsinghsisodya wants to merge 1 commit into
Conversation
knative-prow
Bot
added
the
area/test-and-release
knative-prow
Bot
added
size/XS
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Updates the YAML generation helper script to avoid shell word-splitting risks when cleaning the output directory.
Changes:
- Quote
${YAML_OUTPUT_DIR}in therm -frcleanup command to safely handle paths containing spaces.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Without quotes, a path containing spaces causes incorrect glob expansion and may silently delete the wrong files or fail unexpectedly.
2ebb215 to
a827def
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya, evankanderson The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8990 +/- ##
=======================================
Coverage 51.05% 51.06%
=======================================
Files 409 409
Lines 21990 21990
=======================================
+ Hits 11228 11230 +2
+ Misses 9899 9898 -1
+ Partials 863 862 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Ankitsinghsisodya: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@evankanderson it failed due to the flaky test. Can you again run the test sir. |
- generate-yamls.sh: quote YAML_OUTPUT_DIR in rm command - release.sh: quote dirname substitution, REPO_ROOT_DIR in cp, and $@ - verify-codegen.sh: quote REPO_ROOT_DIR inside mktemp call Unquoted variable expansions and command substitutions break when paths contain whitespace. Closes knative#8990 Closes knative#8992 Closes knative#9004
#9018) * hack: fix unquoted variables in hack scripts to prevent word-splitting - generate-yamls.sh: quote YAML_OUTPUT_DIR in rm command - release.sh: quote dirname substitution, REPO_ROOT_DIR in cp, and $@ - verify-codegen.sh: quote REPO_ROOT_DIR inside mktemp call Unquoted variable expansions and command substitutions break when paths contain whitespace. Closes #8990 Closes #8992 Closes #9004 * hack: use mapfile array for safe multi-file cp in release.sh Using a quoted space-delimited string with cp treats all paths as a single argument and breaks with multiple files. Read YAML_LIST into a local array with mapfile for the cp call, while keeping ARTIFACTS_TO_PUBLISH as a space-separated string that the upstream knative/hack release.sh expects. * hack: remove unused ARTIFACTS_TO_PUBLISH variable * ci: update actions/checkout to v6 in knative-downstream workflow * Revert "ci: update actions/checkout to v6 in knative-downstream workflow" This reverts commit 28805a6.
Fixes #8989
Summary
${YAML_OUTPUT_DIR}in therm -frcall inhack/generate-yamls.shWithout quotes, a path containing spaces causes word-splitting and may silently delete files in the wrong location.