Skip to content

Fix #387 Panic if Redis client returns use of closed network connection #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #387 Panic if Redis client returns use of closed network connection #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/source/adapter/adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,9 @@ func (a *Adapter) processEntry(ctx context.Context, conn redis.Conn, streamName
reply, err := conn.Do("XREADGROUP", "GROUP", groupName, consumerName, "COUNT", count, "BLOCK", blockms, "STREAMS", streamName, xreadID)
if err != nil {
a.logger.Error("Cannot read from stream", zap.Error(err))
if strings.Contains(strings.ToLower(err.Error()), "use of closed network connection") { // Redis has probably been shut down
panic("Redis has been shut down")
}
Comment on lines +186 to +188
Copy link
Member

@Cali0707 Cali0707 Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a more graceful way to handle this error? From the original issue, it seems like the proposed solution is:

Eventing-redis should reopen a socket when the error is "use of closed network connection".

I imagine that with this panicking, it will eventually be restarted and that would reopen the socket. But, I feel like we could handle this more gracefully. WDYT?

if !isShuttingDown {
time.Sleep(1 * time.Second)
}
Expand Down
Loading