Repository navigation
Bump the test cert-manager to v1.21.3 and trust-manager to v0.26.0 - #4830
Merged
Merged
Conversation
knative-prow
Bot
added
the
size/XL
knative-prow
Bot
added
the
approved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
[shellcheck (suggestion)] reported by reviewdog 🐶
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4830 +/- ##
==========================================
- Coverage 29.22% 29.20% -0.02%
==========================================
Files 296 296
Lines 16402 16402
==========================================
- Hits 4793 4791 -2
- Misses 11146 11147 +1
- Partials 463 464 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
Contributor
|
/approve |
cert-manager v1.20 can store two private keys for one new Certificate when its cache lags behind. It then checks the request against the wrong key, fails it with "CSR not signed by referenced private key", and waits 1 hour before it tries again (cert-manager/cert-manager#6331). The e2e setup waits about 5 minutes for trust-manager, so the job fails with "Failed to install trust manager". This failed #4807, #4808, #4820 and #4828 between 2026-10-20 and 2026-10-27. Since v1.21.0 the keymanager reads the Certificate and its key Secret from the API server before it creates a key, so it does not make a second one. v1.21 also removes the cert-manager-tokenrequest Role and RoleBinding and renames the metrics Service port to http-metrics. The tests use neither. trust-manager v0.25.0 injects the webhook CA from the trust-manager-tls Secret instead of through the Certificate. v0.26.0 drops the compromised eMudhra roots from the default CA package. The Bundle CRD still serves v1alpha1, which the eventing TLS Bundle uses, and that Bundle does not use the default CAs.
gauron99
force-pushed
the
gauron99/cert-manager-v1.21.3
branch
from
October 27, 2026 17:14
0b2370f to
ab93b38
Compare
gauron99
changed the title
Contributor
Author
|
/retest |
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cert-manager v1.20 can store two private keys for one new Certificate when its cache lags behind. It then checks the request against the wrong key, fails it with "CSR not signed by referenced private key", and waits 1 hour before it tries again (cert-manager/cert-manager#6331). The e2e setup waits about 5 minutes for trust-manager, so the job fails with "Failed to install trust manager" before any test runs.
Since v1.21.0 the keymanager reads the Certificate and its key Secret from the API server before it creates a key, so it does not make a second one.
Seen 4 times in the last week, each with two temporary key Secrets and
failedIssuanceAttempts: 1in the cluster dump:Outside the CRDs, the cert-manager manifest changes only in two places: v1.21 removes the
cert-manager-tokenrequestRole and RoleBinding, and renames the metrics Service port tohttp-metrics. The tests use neither.trust-manager goes from v0.24.0 to v0.26.0. v0.25.0 injects the webhook CA from the
trust-manager-tlsSecret instead of through the Certificate, and v0.26.0 drops the compromised eMudhra roots from the default CA package. The Bundle CRD still servesv1alpha1, which the eventing TLS Bundle uses, and that Bundle does not use the default CAs.cc @dsimansk