Skip to content

[release-1.20] Set rules in pods.defaulting webhook already during creation - #4580

Merged
knative-prow[bot] merged 1 commit into
knative-extensions:release-1.20from
knative-prow-robot:cherry-pick-4576-to-release-1.20
Nov 13, 2025
Merged

knative-prow[bot] merged 1 commit into
knative-extensions:release-1.20from
knative-prow-robot:cherry-pick-4576-to-release-1.20

Conversation

@knative-prow-robot

Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #4576

Set `rules` already in the `pods.defaulting` MWC resource to avoid pods slipping through
  - `rules` are also set by the `kafka-webhook-eventing` but if e.g. the StatefulSet `kafka-source-dispatcher` is created before that its pods would be created without being modified by this MWC

@knative-prow
knative-prow Bot requested review from Cali0707 and aliok November 10, 2025 07:05
@knative-prow knative-prow Bot added area/test size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 10, 2025
@codecov

codecov Bot commented Nov 10, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.81%. Comparing base (9e3466a) to head (4ec7cf2).
⚠️ Report is 1 commits behind head on release-1.20.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.20    #4580   +/-   ##
=============================================
  Coverage         29.81%   29.81%           
=============================================
  Files               294      294           
  Lines             15611    15611           
=============================================
  Hits               4655     4655           
  Misses            10503    10503           
  Partials            453      453           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Cali0707 Cali0707 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest-required

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2025
@knative-prow

knative-prow Bot commented Nov 12, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
@creydr

creydr commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

/retest-required

1 similar comment
@creydr

creydr commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

/retest-required

@knative-prow
knative-prow Bot merged commit 6330233 into knative-extensions:release-1.20 Nov 13, 2025
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants