Skip to content

Fix: add 'clean' to maven package command and fix profiler. #4568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: add 'clean' to maven package command and fix profiler. #4568

wants to merge 1 commit into from

Conversation

@twoGiants
Copy link
Contributor

@twoGiants twoGiants commented Oct 31, 2025

This fixes the shaded build with current Quarkus version. The same was done for data plane unit tests in #4453.

Fixes #4567

Proposed Changes

  • 🐛 Add clean to mvnw package command in profiler script

/cc @Cali0707 @creydr @gauron99 @dsimansk

@knative-prow knative-prow bot added area/data-plane size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2025
@gauron99
Copy link

gauron99 commented Oct 31, 2025

thanks!
/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2025
@gauron99
Copy link

gauron99 commented Oct 31, 2025

/hold for profiling tests

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.82%. Comparing base (0ff8c27) to head (b45f7a5).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4568   +/-   ##
=======================================
  Coverage   28.82%   28.82%           
=======================================
  Files         294      294           
  Lines       16147    16147           
=======================================
  Hits         4655     4655           
  Misses      11039    11039           
  Partials      453      453

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@twoGiants twoGiants force-pushed the issue-4567-fix-failing-profiling branch from dea8164 to bfb80cf Compare October 31, 2025 11:08
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025
@twoGiants
Copy link
Contributor Author

twoGiants commented Oct 31, 2025

retest-required

@gauron99
Copy link

gauron99 commented Oct 31, 2025

/retest

1 similar comment
@twoGiants
Copy link
Contributor Author

twoGiants commented Oct 31, 2025

/retest

@gauron99
Copy link

gauron99 commented Oct 31, 2025

/retest-required

@gauron99
Copy link

gauron99 commented Oct 31, 2025

/retest

@gauron99
Copy link

gauron99 commented Oct 31, 2025

/test upgrade-tests

5 similar comments
@twoGiants
Copy link
Contributor Author

twoGiants commented Oct 31, 2025

/test upgrade-tests

@gauron99
Copy link

gauron99 commented Nov 1, 2025

/test upgrade-tests

@gauron99
Copy link

gauron99 commented Nov 1, 2025

/test upgrade-tests

@gauron99
Copy link

gauron99 commented Nov 1, 2025

/test upgrade-tests

@gauron99
Copy link

gauron99 commented Nov 1, 2025

/test upgrade-tests

@creydr
Copy link
Contributor

creydr commented Nov 7, 2025

@twoGiants thank a lot for working on this.
Can you rebase your PR to get the latest changes from main (which should fix the upgrade test jobs too)?

@twoGiants @creydr
fix: add 'clean' to maven package command
b45f7a5 
This fixes the shaded build with current Quarkus version. The same was
done for data plane unit tests in this PR:
knative-extensions#4453.

Replaced old tracing path with observability path. This was forgotten
after Otel migration.

Issue knative-extensions#4567

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
@creydr creydr force-pushed the issue-4567-fix-failing-profiling branch from bfb80cf to b45f7a5 Compare November 13, 2025 09:06
@creydr
Copy link
Contributor

creydr commented Nov 13, 2025

@twoGiants I rebased your PR to get the latest changes from main into this (to fix some e2e tests)

@creydr
Copy link
Contributor

creydr commented Nov 13, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, gauron99, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Contributor

creydr commented Nov 13, 2025

/retest-required

creydr
creydr reviewed Nov 14, 2025
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2025
@creydr
Copy link
Contributor

creydr commented Nov 17, 2025

/retest-required

2 similar comments
@creydr
Copy link
Contributor

creydr commented Nov 17, 2025

/retest-required

@creydr
Copy link
Contributor

creydr commented Nov 17, 2025

/retest-required

@simkam
Copy link
Contributor

simkam commented Nov 20, 2025

/test integration-tests

@knative-prow
Copy link

knative-prow bot commented Nov 20, 2025

@twoGiants: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-tests_eventing-kafka-broker_main b45f7a5 link true /test integration-tests
reconciler-tests-namespaced-broker_eventing-kafka-broker_main b45f7a5 link unknown /test reconciler-tests-namespaced-broker

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@creydr creydr creydr left review comments

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@dsimansk dsimansk Awaiting requested review from dsimansk

@gauron99 gauron99 Awaiting requested review from gauron99

Assignees

@creydr creydr

@gauron99 gauron99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Profiling fails on main.

4 participants

@twoGiants @gauron99 @creydr @simkam