Fix ignored `DISPATCHERS_MIN_REPLICAS` environment variable. by twoGiants · Pull Request #4555 · knative-extensions/eventing-kafka-broker

twoGiants · 2025-10-09T16:44:23Z

Proposed Changes

Add MinReplicas to copied config in createKafkaScheduler.
Cover bug with test.
Extract duplicated test setup code into function and replace.
Remove // Todo ... => replace strings with existing constants.

Release Note

The DISPATCHERS_MIN_REPLICAS environment variable can now be used to control the dispatcher replicas

Cali0707 · 2025-10-09T16:50:45Z

@twoGiants it looks like these changes introduced some test failures - can you look into those?

twoGiants · 2025-10-09T16:58:30Z

@Cali0707 yep!

codecov · 2025-10-10T10:30:14Z

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.10%. Comparing base (06d47e7) to head (03c2c29).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...l-plane/pkg/reconciler/consumergroup/controller.go	25.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4555   +/-   ##
=======================================
  Coverage   30.10%   30.10%           
=======================================
  Files         294      294           
  Lines       19543    19543           
=======================================
+ Hits         5883     5884    +1     
+ Misses      13207    13206    -1     
  Partials      453      453

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add MinReplicas to copied config in `createKafkaScheduler`. Cover bug with test and clean up the code a little. Extract duplicated code into function and replace strings with existing constants. Issue knative-extensions#4542. Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>

twoGiants · 2025-10-10T13:18:24Z

/test integration-tests

Cali0707

/lgtm
/approve

Cali0707 · 2025-10-10T14:27:11Z

/cherry-pick release-1.19

knative-prow-robot · 2025-10-10T14:27:13Z

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow · 2025-10-10T14:27:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Cali0707]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow-robot · 2025-10-10T14:28:53Z

@Cali0707: new pull request created: #4557

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

twoGiants · 2025-10-24T10:42:00Z

/cherry-pick release-1.18

knative-prow-robot · 2025-10-24T10:42:50Z

@twoGiants: #4555 failed to apply on top of branch "release-1.18":

Applying: Fix ignored `DISPATCHERS_MIN_REPLICAS` env var.
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/consumergroup/controller.go
M	control-plane/pkg/reconciler/consumergroup/evictor_test.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane/pkg/reconciler/consumergroup/evictor_test.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/consumergroup/evictor_test.go
Auto-merging control-plane/pkg/reconciler/consumergroup/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix ignored `DISPATCHERS_MIN_REPLICAS` env var.

Details

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

) Add MinReplicas to copied config in `createKafkaScheduler`. Cover bug with test and clean up the code a little. Extract duplicated code into function and replace strings with existing constants. Issue knative-extensions#4542. Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>

Add MinReplicas to copied config in `createKafkaScheduler`. Cover bug with test and clean up the code a little. Extract duplicated code into function and replace strings with existing constants. Issue #4542. Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>

knative-prow Bot added the area/control-plane label Oct 9, 2025

knative-prow Bot requested review from matzew and pierDipi October 9, 2025 16:44

knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2025

twoGiants force-pushed the issue-4542-dispatchers-min-replicas-not-respected branch 2 times, most recently from 22c7828 to 036240c Compare October 10, 2025 10:25

twoGiants force-pushed the issue-4542-dispatchers-min-replicas-not-respected branch from 036240c to 03c2c29 Compare October 10, 2025 11:01

Cali0707 approved these changes Oct 10, 2025

View reviewed changes

knative-prow Bot assigned Cali0707 Oct 10, 2025

knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025

knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025

knative-prow Bot merged commit bbaf9f1 into knative-extensions:main Oct 10, 2025
34 of 38 checks passed

knative-prow-robot mentioned this pull request Oct 10, 2025

[release-1.19] Fix ignored DISPATCHERS_MIN_REPLICAS environment variable. #4557

Merged

twoGiants mentioned this pull request Oct 24, 2025

[release-1.18] Fix ignored DISPATCHERS_MIN_REPLICAS environment variable. #4565

Merged

creydr mentioned this pull request Nov 4, 2025

Question: Scaling kafka-channel-dispatcher without KEDA #4426

Closed

Navigation Menu

Repository navigation

Fix ignored `DISPATCHERS_MIN_REPLICAS` environment variable. - #4555

Fix ignored `DISPATCHERS_MIN_REPLICAS` environment variable.#4555
knative-prow[bot] merged 1 commit into
knative-extensions:mainfrom
twoGiants:issue-4542-dispatchers-min-replicas-not-respected

twoGiants commented Oct 9, 2025

Uh oh!

Cali0707 commented Oct 9, 2025

Uh oh!

twoGiants commented Oct 9, 2025

Uh oh!

codecov Bot commented Oct 10, 2025 •

edited

Loading

Uh oh!

twoGiants commented Oct 10, 2025

Uh oh!

Cali0707 left a comment

Uh oh!

Cali0707 commented Oct 10, 2025

Uh oh!

knative-prow-robot commented Oct 10, 2025

Uh oh!

knative-prow Bot commented Oct 10, 2025

Uh oh!

Uh oh!

knative-prow-robot commented Oct 10, 2025

Uh oh!

twoGiants commented Oct 24, 2025

Uh oh!

knative-prow-robot commented Oct 24, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

twoGiants commented Oct 9, 2025

Proposed Changes

Uh oh!

Cali0707 commented Oct 9, 2025

Uh oh!

twoGiants commented Oct 9, 2025

Uh oh!

codecov Bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

twoGiants commented Oct 10, 2025

Uh oh!

Cali0707 left a comment

Choose a reason for hiding this comment

Uh oh!

Cali0707 commented Oct 10, 2025

Uh oh!

knative-prow-robot commented Oct 10, 2025

Uh oh!

knative-prow Bot commented Oct 10, 2025

Uh oh!

Uh oh!

knative-prow-robot commented Oct 10, 2025

Uh oh!

twoGiants commented Oct 24, 2025

Uh oh!

knative-prow-robot commented Oct 24, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Oct 10, 2025 •

edited

Loading