Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-organize reviewmacro files #1053

Merged
merged 1 commit into from
Jun 25, 2018
Merged

re-organize reviewmacro files #1053

merged 1 commit into from
Jun 25, 2018

Conversation

takahashim
Copy link
Collaborator

  • reviewmacro: entry point
  • review-base: base definition
  • review-style: style definition
  • review-custom: user-defined macros

@takahashim
re-organize reviewmacro files
78d1848 
* reviewmacro: entry point
* review-base: base definition
* review-style: style definition
* review-custom: user-defined macros
@takahashim
Copy link
Collaborator Author

#917 (comment) に合わせたものです。

@kmuto
Copy link
Owner

kmuto commented Jun 25, 2018

特に反対はないです。jsbookのほうは旧来互換性維持用なのでbase側にstyle定義がいりまじってるのはしょうがないですね…。

早く新しい皮袋にしていきたい。

@takahashim
Copy link
Collaborator Author

ではマージしますね。
jlreqの方もbaseとcustomは切り分けるのが後々のバージョンアップに対応しやすくなりそうです。

@takahashim takahashim merged commit 0d8969f into master Jun 25, 2018
@takahashim takahashim deleted the review-macro branch June 25, 2018 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takahashim @kmuto