Open
Conversation
This would not drop the original but only the copy. Here's the
clippy error:
calls to `std::mem::drop` with a value that implements `Copy`. Dropping a copy leaves the original intact
error: calls to `std::mem::drop` with a value that implements `Copy`. Dropping a copy leaves the original intact
--> src/decoder.rs:128:5
|
128 | drop(elem_size);
| ^^^^^^^^^^^^^^^
|
= note: `#[deny(clippy::drop_copy)]` on by default
note: argument has type u32
--> src/decoder.rs:128:10
|
128 | drop(elem_size);
| ^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy
More details can be found here: https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
This should be reverted when I sorted out why clippy failed to apply its suggestions.
Otherwise we would need to depend on std to import f32 and f64 constants.
This reverts commit c44a4de.
Owner
Author
|
A merge is blocked by rust-lang/rust#91523 |
bbaf33d to
9d829a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clippy produced broken code when applying the remaining fix: