-
Notifications
You must be signed in to change notification settings - Fork 6
chore: fix typo in comment #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kleros-escrow-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughCorrected two NatSpec comment typos in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 🧹 Recent nitpick comments
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
contracts/src/interfaces/IEscrow.sol (1)
79-79: Nit: tighten phrasing for clarityConsider “on behalf of the buyer” to avoid the ambiguous “their”.
Apply:
-/// @param _buyer Party that pays for the transaction. Note that msg.sender can provide funds on their behalf. +/// @param _buyer Party that pays for the transaction. Note: msg.sender can provide funds on behalf of the buyer.Also applies to: 94-94
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
contracts/src/interfaces/IEscrow.sol(2 hunks)
🔇 Additional comments (1)
contracts/src/interfaces/IEscrow.sol (1)
79-79: Typo corrected in IEscrow.sol — no further occurrences in sourceI ran the suggested ripgrep search and only found the typo in auto-generated JSON metadata (not in any live Solidity files). No other “provides finds” or similar variants remain in the codebase. LGTM.
PR-Codex overview
This PR focuses on correcting a typo in the documentation comments of the
createNativeTransactionandcreateERC20Transactionfunctions in theIEscrowinterface. The word "finds" is updated to "funds" to accurately reflect the intended meaning.Detailed summary
createNativeTransactionfunction.createERC20Transactionfunction.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.