-
Notifications
You must be signed in to change notification settings - Fork 14
Implement dwell timers #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
715ec05
Initialize on geofence event (#460)
belleklaviyo 2d37272
Add duration field to Geofence object
belleklaviyo e771c52
Add dwell timers and dwell event firing
belleklaviyo d6c726d
Add mock stub (for now) to test duration
belleklaviyo 7fe48ad
Create DwellTimerTracker for persistence
belleklaviyo 1fba188
Add checkExpiredDwellTimers func to fire dwell events
belleklaviyo b24771b
add DwellTimerTracker to KlaviyoLocationManager
belleklaviyo 6c0962f
Add and remove timers from DwellTimerTracker in lifecycle
belleklaviyo 65fee38
Check and fire expired persisted dwell events on foreground, backgrou…
belleklaviyo f99074c
Rename some things for clarity
belleklaviyo 931c3eb
Add tests
belleklaviyo 72f2a2b
Restore real API call
belleklaviyo 543fae4
Simplify getExpiredTimers to only concern itself with persisted ones,…
belleklaviyo 6575fcc
Modify DwellTimerData to contain apiKey to make correct createGeofenc…
belleklaviyo 44a47de
Invalidate tiemrs in memory if they fired from persistence
belleklaviyo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -105,9 +105,9 @@ extension KlaviyoLocationManager: CLLocationManagerDelegate { | |
| } | ||
| } | ||
|
|
||
| extension KlaviyoLocationManager { | ||
| // MARK: Dwell Timer Management | ||
| // MARK: Dwell Timer Management | ||
|
|
||
| extension KlaviyoLocationManager { | ||
| private func startDwellTimer(for klaviyoLocationId: String) { | ||
| cancelDwellTimer(for: klaviyoLocationId) | ||
| guard let dwellSeconds = geofenceDwellSettings[klaviyoLocationId] else { | ||
|
|
@@ -166,4 +166,32 @@ extension KlaviyoLocationManager { | |
| Logger.geoservices.info("🕐 Dwell event fired for region \(klaviyoLocationId)") | ||
| } | ||
| } | ||
|
|
||
| /// Check for expired timers and fire dwell events for them | ||
| /// Called on app launch/foreground as a best-effort recovery mechanism | ||
| @MainActor | ||
| func checkExpiredDwellTimers() { | ||
| let expiredTimers = dwellTimerTracker.checkExpiredTimers(activeTimerIds: Set(dwellTimers.keys)) | ||
|
|
||
| // Fire dwell events for expired timers | ||
| for (geofenceId, duration) in expiredTimers { | ||
| let dwellEvent = Event( | ||
| name: .locationEvent(.geofenceDwell), | ||
| properties: [ | ||
| "$geofence_id": geofenceId, | ||
| "$geofence_dwell_duration": duration | ||
| ] | ||
| ) | ||
|
|
||
| Task { | ||
| await MainActor.run { | ||
| KlaviyoInternal.create(event: dwellEvent) | ||
| } | ||
| } | ||
|
|
||
| if #available(iOS 14.0, *) { | ||
| Logger.geoservices.info("🕐 Fired expired dwell event for region \(geofenceId) (expired while app was terminated)") | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should go inside the |
||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.