Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code of conduct suggested by github #62

Merged
merged 3 commits into from
Jan 15, 2022
Merged

Conversation

mossroy
Copy link
Contributor

@mossroy mossroy commented Dec 20, 2021

This is the code of conduct that GitHub suggested when I started adding a similar file.
I find it suitable for us, but we can adapt it if we want (or replace it by another one we would prefer)

Fixes #61

@Popolechien
Copy link
Member

Question: how different is it from the CoC (itself derived from the standard Contributor Covenant) found at https://github.com/kiwix/kiwix-android/blob/develop/CODE_OF_CONDUCT.md ?

@mossroy
Copy link
Contributor Author

mossroy commented Dec 20, 2021

@Popolechien : interesting, I was not aware this file existed for kiwix-android!
It seems to be the same source but an older version (from contributor-covenant 1.4, where this PR is from 2.0)
The email is also slightly different : [email protected] on kiwix-android, where I had simply put [email protected]

Copy link
Member

@Jaifroid Jaifroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code of conduct looks good, with just one possible edit noted. Do you want to include a link to it from the README in this PR?

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@Jaifroid
Copy link
Member

Oops, sorry, I thought I was reviewing this on Kiwix JS. Of course the PR can't include the links to it in that case.

Copy link
Member

@Popolechien Popolechien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest using [email protected] as email address

@mossroy
Copy link
Contributor Author

mossroy commented Dec 20, 2021

Would suggest using [email protected] as email address

Done

@mossroy
Copy link
Contributor Author

mossroy commented Jan 4, 2022

@kelson42 and @Popolechien : do you want more changes on this Code Of Conduct?

@Popolechien
Copy link
Member

Popolechien commented Jan 4, 2022

@mossroy Fine by me, but @kelson42 is the boss here.

@mossroy
Copy link
Contributor Author

mossroy commented Jan 10, 2022

@kelson42 : can we merge this PR?
It would allow us to copy this file in kiwix-js too

@kelson42 kelson42 merged commit afd378a into master Jan 15, 2022
@kelson42 kelson42 deleted the add-code-of-conduct branch January 15, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Code of Conduct
4 participants