Save the back stack of visited pages before exiting from app #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhutti1 I have implemented the back stack save and restore feature. The only work that remains is of showing them in proper order. I will complete the PR in a couple of days as I am busy with my exams. |
|
@RohanBh Please update the PR incase you're free now. Ignore otherwise. |
|
I couldn't find a direct way of doing this. Also, the method I was trying is not able to solve the issue as webview behaves differently than I thought. I might need more time. |
RohanBh
force-pushed
the
fix-webview-back-stack
branch
from
0df824b to
d23b893
Compare
RohanBh
changed the title
|
@mhutti1 I have finally completed the PR. |
|
@mhutti1 please take a look at this PR. |
mhutti1
suggested changes
Apr 12, 2018
| */ | ||
| public static void writeBundleToStorage(final @NonNull Application app, Bundle writeBundle) { | ||
| Observable.just(writeBundle) | ||
| .observeOn(Schedulers.io()) |
There was a problem hiding this comment.
4 Space continuations please. In multiple places in this PR.
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398
Changes: Saved a webview state bundle to a file and restored the webview's state via that bundle on app startup. All I/O operations have been done on a new thread.
Screenshots/GIF for the change: