-
-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes of Display Navigation History #3239
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3239 +/- ##
=============================================
+ Coverage 49.62% 50.15% +0.53%
Complexity 25 25
=============================================
Files 299 304 +5
Lines 10010 10162 +152
Branches 1329 1348 +19
=============================================
+ Hits 4967 5097 +130
+ Misses 4356 4355 -1
- Partials 687 710 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This is exactly what we want: remove old traces of navigation. What is the problem? |
@kelson42 , I'm not implementing this because ,let's suppose user on 7th page and he clear the history, then he can not go back to previous page or forward if any page in forward (then current page will become the first page).
Okay if this is the case ,i'm implementing this it's need a small change in code. |
@gouri-panda can you please review this PR? |
a1d499f
to
21da71e
Compare
@kelson42 , I have rebase the PR and resolved the conflicts. @gouri-panda now you can re-review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MohitMaliFtechiz Thanks 🎉
Fixes #3042
WebBackForwardList
list ofWebView
class for showing navigation history(backward and forward).NavigationHistory
to user (this list is scrollable), when user long click on backward and forward button.NavigationHistoryTest
) for testing this functionality.@kelson42 , since we are not saving history to database, we are using webview history for showing backward and forward list. In webview we have only one methodclearHistory()
to clear the history(but it will clear full history for currently opened book, so user can not go back and forward. so that's why i have not implemented this).navigation.history.mp4