various small fixes #166
Merged
various small fixes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix relint config * replace some relint entries with ruff rules * organize ruff rules into correct sections * enable ruff isort * remove unnecessary pytester abstraction
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 287 286 -1
Branches 54 33 -21
=========================================
- Hits 287 286 -1 ☔ View full report in Codecov by Sentry. |
|
my god commitsar drives me crazy 🙃 |
jakkdl
force-pushed
the
network_block_message
branch
from
31e0e24 to
c675625
Compare
Stranger6667
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filenameoption have had no effect)which are gonna be more comprehensive
didn't notice the warning in my previous PR
Given that isort was configured I was very confused why it wasn't enabled
When reading the tests I noticed a bunch of unnecessary pytester invocations. Maybe there's a case for keeping the same style for each test, but for simple tests that didn't need it I just found it confusing and it'd make debugging trickier. It also stops the code from being covered by linters & type-checkers.
One day I'll get to actually fixing the issues I've been asked to address 😅