fix: company settings mapped to incorrect fields in frontend#121
Merged
Conversation
Contributor
Author
|
As far as I can tell, this also solves the issue in #117 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Been looking into this project for a while, really like the idea of it all.
Have encountered a few bugs while playing around with the 2.0.1 version.
Seems more people have encountered this one specifically: #120
The bug:
Some company settings fields will always render the default values to invoices. This is due to the ui setting the fields email, phone, taxId, countryCode instead of companyEmail, companyPhone, companyTaxId, companyCountryCode that is referenced by templates.
There is some mention of potential aliases here:
Invio/backend/src/controllers/settings.ts
Lines 19 to 31 in 84d6d5c
That is never handled in anyway though and as a result, both versions are stored in the settings table in db.
This pr simply makes the UI reference the fields the way the rest of the app expects it to.