feat: Add OIDC authentication and SMTP email notifications#114
Merged
Conversation
Owner
|
Hi in your PR you list you have added two new invoice templates but when looking through your commits I don't see them anywhere. You also provided a test checklist, have you tested the things you list there. Anyway thank you for creating a PR! Would be happy to merge this. |
Contributor
Author
|
Hey, sorry. I forgot the push the Templates update. I've pushed it now. I have independently verified and tested everything. |
Owner
|
Ah, no worries! Everything looks good so I am gonna go ahead and merge this. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/auth/callbackroute, and full OIDC session handling. Tested with Authentik; should work with any compliant OIDC provider. Supports optional auto-provisioning of new accounts on first SSO login.Changes
backend/src/utils/oidc.ts,backend/src/routes/auth.tsfrontend/src/routes/auth/callback/+server.ts,login/+page.sveltebackend/src/utils/email.ts,backend/src/routes/admin.tsfrontend/src/routes/invoices/[id]/+page.svelte,+page.server.tsbackend/src/database/init.ts,migrations.sql.env.exampleTest plan
.env, verify SSO login redirects and callback creates a valid sessionOIDC_ENABLEDunset orfalse)