Skip to content

Comments

[MAINTENANCE] Adjust css class names in TOC Plugin#1846

Open
beatrycze-volk wants to merge 2 commits intokitodo:mainfrom
beatrycze-volk:toc-classes
Open

[MAINTENANCE] Adjust css class names in TOC Plugin#1846
beatrycze-volk wants to merge 2 commits intokitodo:mainfrom
beatrycze-volk:toc-classes

Conversation

@beatrycze-volk
Copy link
Collaborator

No description provided.

@beatrycze-volk beatrycze-volk self-assigned this Feb 11, 2026
@beatrycze-volk beatrycze-volk added the ⟳ maintenance A task to keep the code up-to-date and manageable. label Feb 11, 2026
Copy link
Member

@sebastian-meyer sebastian-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the renaming? Everybody who uses the default templates will have to adjust their CSS files...

@beatrycze-volk
Copy link
Collaborator Author

Because we use here mixed naming conventions:

<div class="tx-dlf-tableofcontents">
    <ul>
        <f:render partial="TableOfContents/Children" arguments="{children: toc, viewData: viewData}"/>
    </ul>
</div>

Ine the Main.html we have tx-dlf-tableofcontents, and then tx-dlf-toc. It would be good to unify it. It matches the standard approach where css classes are created 'tx-dlf-pluginname-xyz'.

Plus new names are more clear and descriptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⟳ maintenance A task to keep the code up-to-date and manageable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants