Skip to content

Fixed a crash that could result daily for some players.#6

Open
sin-0f-pride wants to merge 1 commit intokirnosenko:masterfrom
sin-0f-pride:master
Open

Fixed a crash that could result daily for some players.#6
sin-0f-pride wants to merge 1 commit intokirnosenko:masterfrom
sin-0f-pride:master

Conversation

@sin-0f-pride
Copy link

Probably happens when the tick runs while the ruling clan leader is dead and the logic to set the new one hasn't happened yet, but it's unclear.

@kirnosenko
Copy link
Owner

I don't think the game itself sets it to null at some point. Another mod maybe. Did you actually catch the crash? Have a crash report?

@sin-0f-pride
Copy link
Author

It probably is, but I didn't go through to figure out which mod was causing it. The reports were submitted to me on my discord, and the user also posted them on the Nexus Mod Page

@kirnosenko
Copy link
Owner

It could be anything. Probably from another thread. In that case your code is not right way to fix it. You need some sort of thread locking. But to do so it is necessary to fully understand what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants