Skip to content

fix(ios): ignore keyboard events that don't originate from this app #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ridafkih wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −4
Open

fix(ios): ignore keyboard events that don't originate from this app #1512

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7d410e
fix(ios): ignore keyboard events that don't originate from this app
ridafkih Jun 23, 2026
27937e8
refactor(ios): collapse preloading + local checks into canBeSafelyIgn…
ridafkih Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ios/extensions/Notification.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ extension Notification {

return (duration, keyboardFrame)
}

var isLocalKeyboardEvent: Bool {
(userInfo?[UIResponder.keyboardIsLocalUserInfoKey] as? Bool) != false
}
}

extension Notification.Name {
Expand Down
4 changes: 4 additions & 0 deletions ios/observers/movement/observer/KeyboardMovementObserver+Listeners.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
extension KeyboardMovementObserver {
@objc func keyboardWillAppear(_ notification: Notification) {
guard !UIResponder.isKeyboardPreloading else { return }
guard notification.isLocalKeyboardEvent else { return }
Comment thread
ridafkih marked this conversation as resolved.
Outdated

let (duration, frame) = notification.keyboardMetaData()
if let keyboardFrame = frame {
Expand Down Expand Up @@ -35,6 +36,7 @@ extension KeyboardMovementObserver {

@objc func keyboardWillDisappear(_ notification: Notification) {
guard !UIResponder.isKeyboardPreloading else { return }
guard notification.isLocalKeyboardEvent else { return }
let (duration, _) = notification.keyboardMetaData()
tag = UIResponder.current.reactViewTag
self.notification = notification
Expand All @@ -56,6 +58,7 @@ extension KeyboardMovementObserver {

@objc func keyboardDidAppear(_ notification: Notification) {
guard !UIResponder.isKeyboardPreloading else { return }
guard notification.isLocalKeyboardEvent else { return }

let (duration, frame) = notification.keyboardMetaData()
if let keyboardFrame = frame {
Expand Down Expand Up @@ -83,6 +86,7 @@ extension KeyboardMovementObserver {

@objc func keyboardDidDisappear(_ notification: Notification) {
guard !UIResponder.isKeyboardPreloading else { return }
guard notification.isLocalKeyboardEvent else { return }
let (duration, _) = notification.keyboardMetaData()
tag = UIResponder.current.reactViewTag

Expand Down
Loading