Dashboard design skeleton #14
Merged
+2,262
−720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FearsomeRover What would be the preferred method with the props validation error: Disabling it in eslintrc or writing custom prop types for every component. I know you encountered this problem before in the schbody project, what was the conclusion there? |
|
I usually disable it for the shadcn files. But thats not best practise probably. |
|
As for now the player, right-sidebar and the main content are just placeholders, some more work needs to be done on them |
FearsomeRover
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contains custom font, custom theming
header, sidebar, right-sidebar and the player