Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated object storage #879

Open
wants to merge 14 commits into
base: staging
Choose a base branch
from
Open

Use dedicated object storage #879

wants to merge 14 commits into from
+1,406 −966

Conversation

Isti01
Copy link
Collaborator

@Isti01 Isti01 commented Mar 16, 2025

No description provided.

@Isti01 Isti01 marked this pull request as draft March 16, 2025 13:53
Isti01
Isti01 commented Mar 18, 2025
View reviewed changes
backend/src/main/kotlin/hu/bme/sch/cmsch/util/Utility.kt
@@ -87,15 +55,11 @@ fun Map<String, String>.urlEncode(): String = this.entries.joinToString("&") {
URLEncoder.encode(it.key, StandardCharsets.UTF_8) + "=" + URLEncoder.encode(it.value, StandardCharsets.UTF_8)
}

fun readAsset(assetName: String): Optional<ByteArray> {
fun readBundledAsset(assetName: String): Optional<ByteArray> {
try {
return Optional.of(ClassPathResource(assetName).inputStream.readAllBytes())
} catch (ignored: Throwable) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add logging here

@vercel Vercel
Copy link

vercel bot commented Mar 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmsch-skktv ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 2:44pm

@Isti01 Isti01 marked this pull request as ready for review March 20, 2025 13:43
@Isti01 Isti01 force-pushed the feature/use-dedicated-object-storage branch from bfe6b01 to 2a25895 Compare March 20, 2025 14:37
@Isti01 Isti01 force-pushed the feature/use-dedicated-object-storage branch from 2a25895 to 90b3171 Compare March 20, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albi005 albi005

@berenteb berenteb

@SzBeni2003 SzBeni2003

@triszt4n triszt4n

@Gerviba Gerviba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Isti01 @albi005