feat: add user org pooling #506
Conversation
Deploying kinde-docs-previews with
|
| Latest commit: |
57b5e02
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4fd977cc.kinde-docs-previews.pages.dev |
| Branch Preview URL: | https://feat-user-pooling.kinde-docs-previews.pages.dev |
|
Warning Rate limit exceeded@DanielRivers has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 55 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughA new documentation page titled "Organization User Pools" has been added. This page introduces and explains the concept, benefits, use cases, and setup instructions for Organization User Pools, a multi-tenant user management feature supporting B2B environments. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/content/docs/authenticate/organization-user-pools/user-pools.mdx (4)
32-32: Use plural verb for grammatical agreement
Organization User Poolsis a plural noun phrase, so the verb should be are rather than is.-Organization User Pools is a powerful multi-tenant user management feature that isolates user identities within specific organizations. +Organization User Pools are a powerful multi-tenant user management feature that isolates user identities within specific organizations.
40-44: Add terminal punctuation and tighten wording for list consistencyConsistent punctuation improves readability. While here, switch “Support” → “Supports” for subject-verb agreement.
- - **Identity Isolation**: Users from different organizations cannot access each other's accounts - - **Email Reuse**: The same email address can exist across multiple organizations - - **Secure Multi-tenancy**: Complete data and identity separation between organizations - - **Scalable B2B**: Support unlimited organizations with isolated user management - - **Backward Compatibility**: Works with existing authentication flows + - **Identity Isolation**: Users from different organizations cannot access each other's accounts. + - **Email Reuse**: The same email address can exist across multiple organizations. + - **Secure Multi-tenancy**: Complete data and identity separation between organizations. + - **Scalable B2B**: Supports unlimited organizations with isolated user management. + - **Backward Compatibility**: Works with existing authentication flows.
68-68: Example contradicts the “same email” claimLine 68 uses a different domain, so the addresses are not identical. Either use the exact same email or adjust the parenthetical note.
- - [email protected] (same email, different organization, different password) + - [email protected] (identical email, different organization, different password)
76-76: Clarify enabling prerequisites in a single sentenceThe current wording is repetitive and ambiguous (“account” vs “environment”). Suggest a tighter statement:
-This is disabled by default. This can be enabled by updating the environment settings when the account has no users. +Organization User Pools are disabled by default and can only be enabled in an environment that currently has no users.
DanielRivers
force-pushed
the
feat/user-pooling
branch
from
79ffff4 to
34dcb87
Compare
|
|
||
| This is disabled by default. This can be enabled by updating the environment settings when the account has no users. | ||
|
|
||
| 1. Visit "Settings > Environment Details" |
There was a problem hiding this comment.
You may not be done with the doc Daniel, but please note this is not the style we do steps in. Can you update to:
- Go to Settings > Environment details.
- Switch on the Enable organization user pools option.
- Select Save.
There was a problem hiding this comment.
Also, I wondered if this feature belongs more under Environment > 'Policies' rather than the top level page?
| @@ -0,0 +1,80 @@ | |||
| --- | |||
| page_id: 7e2b8c3a-4f1a-4e2a-9c6b-2d8f7a1b5c3d | |||
| title: Organization User Pools | |||
There was a problem hiding this comment.
Hey Daniel. I don't think 'user pools' should be treated as a proper noun (capitalised) unless it is referring to some actual piece of tech called 'User Pools' (and is an equivalent of 'Twilio' .
If this just refers the feature name we have given it, please make it lower case throughout the doc and in the UI as well. An exception might be the first instance in the doc, where you might use it like you are explaining a term. E.g. Organization 'user pools' refers to the confinement of users to a specific organization... etc. And from then on you can just use lower case. Hope that makes sense.
Description (required)
Add documentation on user pooling
Summary by CodeRabbit