feat: add feature to track every validators in the pool#94
Open
qj0r9j0vc2 wants to merge 4 commits intokilnfi:mainfrom
Open
feat: add feature to track every validators in the pool#94qj0r9j0vc2 wants to merge 4 commits intokilnfi:mainfrom
qj0r9j0vc2 wants to merge 4 commits intokilnfi:mainfrom
Conversation
enable to track all validators in the pool.
set name with moniker for each validator
Member
|
Hello, thanks for your contribution. I don't think I'll merge it as is, since I see some issues with doing it that way.
In my opinion, it makes sense to extract already available data, i.e., attested and missed blocks for each validator, but skip all other parts. That would be an option to fill metrics without displaying more information in the CLI output (i.e., only Is this what you wanted to achieve with this PR (getting the uptime of all validators)? Note that I'd also like to work on exposing the average and percentiles of uptime in order to compare the performance of our validators versus the network, but without the need to store all validators' uptime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add feature to track every validators in the pool.
to track every validators, the chain should have staking module.