refactor: Punt index logic to crates-index #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
changed the title
|
|
|
@ordian looks like this is now ready |
ordian
reviewed
Aug 30, 2021
src/fetch.rs
Outdated
Comment on lines
126
to
136
| fn need_retry(err: crates_index::Error) -> Result<bool> { | ||
| match err { | ||
| crates_index::Error::Git(err) => { | ||
| if err.class() == git2::ErrorClass::Index && err.code() == git2::ErrorCode::Locked { | ||
| Ok(true) | ||
| } else { | ||
| Err(crates_index::Error::Git(err).into()) | ||
| } | ||
| } | ||
| err => Err(err.into()), | ||
| } | ||
| } |
There was a problem hiding this comment.
this function never returns Ok(false), also some docs/comments would be nice
should it take the number of attempts into consideration?
There was a problem hiding this comment.
The lack of Ok(false) was more an API design than. The other patterns I had thought of for this API (like Result<()>) felt like they would be confusing in context.
I do have one idea to possibly make this a little less weird. I'll give that a try.
This was inspired by running into errors where `cargo add inquire` was not adding the latest version. We've seen similar problems during the development of `crates-index`, so hoping what they've done fixes this. Even if it doesn't solve this problem, hopefully by nature of using a shared crate means it will get more use and more eyes to make it more reliable in the long term. Handling retrying the index is annoying. I opened frewsxcv/rust-crates-index#62 Note: in the next version of crates-index - Opening an index will implicitly create it, so we won't be able to differentiate in our message whether we are initializing or updating. See frewsxcv/rust-crates-index#61 - We will be able to open an Index by URL, which will allow us to remove more logic
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was inspired by running into errors where
cargo add inquirewasnot adding the latest version. We've seen similar problems during the
development of
crates-index, so hoping what they've done fixes this.Even if it doesn't solve this problem, hopefully by nature of using a
shared crate means it will get more use and more eyes to make it more
reliable in the long term.
Handling retrying the index is annoying. I opened
frewsxcv/rust-crates-index#62
Note: in the next version of crates-index
differentiate in our message whether we are initializing or updating.
See UI Differentiating between Initializing vs Updating frewsxcv/rust-crates-index#61
more logic