Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create lua/middleclass.lua symlink to origin file #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anuvyklack
Copy link

To make middleclass git repo work with Neovim plugin managers.

To make middleclass git repo work with Neovim plugin managers.
@Issafalcon
Copy link

This symlink approach unfortunately doesn't work on Windows OS. To prevent Noevim plugin authors from unintentionally breaking plugins on Windows, a different approach will be required to allow this repo to be used as a dependency in new Neovim plugins.

@wookayin
Copy link

wookayin commented Sep 20, 2022

In my opinion, windows users can just do git config --global core.symlinks true as a user-wide setting.

But why don't we move ROOT/middleclass.lua -> ROOT/lua/middleclass.lua if out-of-box support for windows users is a concern? (and put a symlink into ROOT). Actually I don't see any reason the file middleclass.lua must be placed on the root directory.

@anuvyklack
Copy link
Author

Everything ingenious is simple!

And create a symlink in the root to the lua/middleclass.lua file.
@Issafalcon
Copy link

Good solution! The git config update would have been fine, with some additional README updates, but this way is much better.

@alerque
Copy link

alerque commented Sep 23, 2022

Why still have the symlink at all? My experience is that will break more cases than it fixes. I would suggest just putting the file where it is usable by all relevant consumers in the first place and adjust usage to assume that location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants