Skip to content

Conversation

@CheNing233
Copy link

@CheNing233 CheNing233 commented Apr 20, 2025

I've merged this PR

Support the end frame control

lllyasviel/FramePack#167

Workflow.json:

framepack-end-frame-control.json

The 1-second test results are as follows:

start frame

image-501339f5-d1a3-423f-9f8d-e375f3a90c61

end frame

image-6f31dca9-4766-4c35-83d4-b67df988adee

result

FramePack_00001-first-end.mp4

civitai post

You can also see it in Civitai

https://civitai.com/posts/15841725

@CheNing233 CheNing233 changed the title End frame control support Add end frame control support Apr 20, 2025
@Crimsonfart
Copy link
Contributor

What is the difference between @kabachuha and your commit?
1 second "Test" makes no sense, please do at least a 10 - 15 second test. (Doesn't have to be high resolution)

@CheNing233
Copy link
Author

What is the difference between @kabachuha and your commit? 1 second "Test" makes no sense, please do at least a 10 - 15 second test. (Doesn't have to be high resolution)

Apologies if this seems like a duplicate PR. I'll continue testing 10-second videos with my RTX 3050 4G GPU until this PR gets closed.

@CheNing233
Copy link
Author

CheNing233 commented Apr 20, 2025

This PR inherits all the flaws from the original implementation, and I don't think I have to wait any longer for my slow testing.

After thorough review, this PR is indeed unnecessary, so I'll close it.

It is hoped that this end frame control technology can become more refined.

@CheNing233 CheNing233 closed this Apr 20, 2025
@CheNing233
Copy link
Author

报错: FramePackSampler.process() got an unexpected keyword argument 'image_end_embeds'

My fork is no longer maintained

I recommend you to use this fork, which implements not only the end frame control, but also the multiple key frames and time prompts.

https://github.com/nirvash/ComfyUI-FramePackWrapper

It looks like experimental, but it 's fun. ♥

@berryyan
Copy link

berryyan commented Apr 22, 2025

赞!成功了!
不过的你C站网址好像是404错误,没法给你点赞了!

@berryyan
Copy link

报错: FramePackSampler.process() got an unexpected keyword argument 'image_end_embeds'

My fork is no longer maintained

I recommend you to use this fork, which implements not only the end frame control, but also the multiple key frames and time prompts.

https://github.com/nirvash/ComfyUI-FramePackWrapper

It looks like experimental, but it 's fun. ♥

看到了 谢谢回馈,没有关系,你的workflow比很多人的清晰很多,符合我们强迫症的需求

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants