-
Notifications
You must be signed in to change notification settings - Fork 7
Download empty report Na 31-2 Bijlage 1 #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
==========================================
- Coverage 92.59% 92.57% -0.03%
==========================================
Files 364 367 +3
Lines 29254 29363 +109
Branches 2215 2217 +2
==========================================
+ Hits 27087 27182 +95
- Misses 2018 2030 +12
- Partials 149 151 +2 ☔ View full report in Codecov by Sentry. |
I think we should be able to stream the ZIP file so that we don't have to keep all PDF files in memory, but that would require structuring the code differently so I'm not sure if it's worth it. |
I'd be happy to implement this in a new PR 👍🏻 |
@marlonbaeten this branch has conflicts |
Fixes #1824
Changes
pdf_gen
module to better handle multiple models and better async supportzip
module to reuse the boilerplate code for creating a ZIP file responseTests
download.ts
) and that the code coverage does not include the playwright test.Performance
embed-typst
the same ZIP takes about 1700 ms te generateembed-typst
it takes about 1600 msHow to test
/elections/1
Screenshot