-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettyprint/produce proof tree #43
base: master
Are you sure you want to change the base?
Conversation
537952b
to
b80c422
Compare
507cb90
to
9a6889d
Compare
I have run the smoke test and things work. Please run any other tests you are concerned about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Is it possible to have tests for either this or reap? Unit tests may be impossible but just some regular input output perhaps?
Thats an idea. Right now the tests are timing out. It looks like Xiaohong is right, and there is a performance issue. I've pushed a PR that reduces changes the set of goals to a list, and only considers the first goal as active. I'll need to re-implement |
b853c84
to
2491890
Compare
Since we are not removing subgoals unless they fail this is no longer necessary
… a single uncomposed strategy
2491890
to
e1dd33a
Compare
This PR adds a script called
lib/render-proof-tree
that pretty prints the proof tree and the current/selected goal.It also changes sequential composition to occur within a subgoal. Performance doesn't seem to have been affected much, but I have not tested that extensively.