Return ResolvedKeystoneConfig instead of KeystoneConfig #9189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f5fbd04:
|
gautamsi
force-pushed
the
return-default-config
branch
from
56e0979 to
a0740f4
Compare
gautamsi
force-pushed
the
return-default-config
branch
from
a0740f4 to
068c5d3
Compare
gautamsi
force-pushed
the
return-default-config
branch
2 times, most recently
from
ab63849 to
395c861
Compare
gautamsi
force-pushed
the
return-default-config
branch
from
395c861 to
946347e
Compare
gautamsi
force-pushed
the
return-default-config
branch
from
946347e to
71a12f8
Compare
Do we actually need to break? The resolved type is only a type refinement, hopefully |
|
we can do minor change for this, as no one was using until now. |
gautamsi
force-pushed
the
return-default-config
branch
from
71a12f8 to
f5fbd04
Compare
|
@dcousens I have updated this to be minor instead of major change. |
gautamsi
force-pushed
the
return-default-config
branch
2 times, most recently
from
34263d9 to
908dc13
Compare
dcousens
force-pushed
the
return-default-config
branch
from
b43d0a2 to
139fce4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__ResolvedKeystoneConfigtoResolvedKeystoneConfig;configfunction so that any config wrapper can make use of defaults.config()now returnsResolvedKeystoneConfiginstead ofKeystoneConfigwithAuthinput now needsResolvedKeystoneConfigBreaking changes due to type change, There is no migration needed in most cases instead of type casting in some case.