Update download dependency and require Node.js 10#77
Open
tjbulick wants to merge 2 commits intokevva:masterfrom
Open
Update download dependency and require Node.js 10#77tjbulick wants to merge 2 commits intokevva:masterfrom
download dependency and require Node.js 10#77tjbulick wants to merge 2 commits intokevva:masterfrom
Conversation
Author
|
Resolves #76 |
|
The CI failures seem unrelated to this PR |
|
Could you check this MR @kevva? 😊 |
Author
|
By the way, i also checked that CI errors don't relate to my changes. But maybe repository maintainer would say that we need to fix them. Anyway, i'm still here and ready to fix them, but it would be nice to hear something from the maintainer. Maybe he will just merge these changes despite CI errors, at least because in past versions he already did so. |
XhmikosR
reviewed
Feb 23, 2021
| @@ -1,5 +1,4 @@ | |||
| language: node_js | |||
| node_js: | |||
| - '12' | |||
Contributor
|
BTW it'd be nice to switch to GitHub Actions. Also, check if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dependency package called
downloadin order to pull in security patch. This also increases required node.js version to 10