Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added job creator role and remove secrets manager role #77

Merged
merged 1 commit into from
Apr 2, 2024
Merged

added job creator role and remove secrets manager role #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 2 additions & 28 deletions terraform/service_accounts.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,3 @@
# #####################################################################################################################
# # The following resource blocks does the following:
# # - Create a custom service account for Cloud Composer
# # - Bind the custom SA to worker role
# # - Add the Service Agent account as a new principal to workspace account and grant it the Service Agent role
# # - Read more on : https://cloud.google.com/composer/docs/composer-2/terraform-create-environments
# #####################################################################################################################
# resource "google_service_account" "custom_composer_account" {
# account_id = "composer-sa"
# display_name = "Custom Service Account for Cloud Composer V2"
# }

# resource "google_project_iam_member" "composer_worker" {
# project = local.id
# member = format("serviceAccount:%s", google_service_account.custom_composer_account.email)
# # Roles for Public IP environments
# role = "roles/composer.worker"
# }

# resource "google_service_account_iam_member" "composer_agent" {
# service_account_id = google_service_account.custom_composer_account.name
# role = "roles/composer.ServiceAgentV2Ext"
# member = "serviceAccount:service-${local.number}@cloudcomposer-accounts.iam.gserviceaccount.com"
# }


resource "google_service_account" "airflow_user_sa" {
account_id = "airflow-user-sa"
display_name = "Custom Service Account for Astro Airflow User"
Expand All @@ -42,8 +16,8 @@ resource "google_project_iam_binding" "bq_access" {
members = ["serviceAccount:${google_service_account.airflow_user_sa.email}"]
}

resource "google_project_iam_binding" "gsm_access" {
resource "google_project_iam_binding" "bq_job_creator" {
project = local.id
role = "roles/secretmanager.secretAccessor"
role = "roles/bigquery.jobUser"
members = ["serviceAccount:${google_service_account.airflow_user_sa.email}"]
}
Loading