Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): print help on missing parameters #7130

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

yuri1969
Copy link
Contributor

What changes are being made and why?

Missing required positional parameters caused just a stacktrace print.

Now such cases print the error message accompanied by command's help.


How the changes have been QAed?

Examples:

  • ./kestra flow namespace update
  • ./kestra flow dot

Missing required positional parameters caused just a stacktrace print.

Now such cases print the error message acompanied by command's help.

Examples:

* `./kestra flow namespace update`
* `./kestra flow dot`
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thansk

@anna-geller
Copy link
Member

Approved but not merged, why?

@loicmathieu
Copy link
Member

@anna-geller, well, be a little patient...

@loicmathieu loicmathieu merged commit ae05de4 into kestra-io:develop Feb 3, 2025
8 checks passed
@anna-geller
Copy link
Member

I thought there is perhaps some merge freeze due to RC - thx for clarifying!

@yuri1969 yuri1969 deleted the cli-help-everywhere branch February 3, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants