feat(portfolio): add getPositionLots endpoint for per-position tax lots - #9
Open
samyk wants to merge 1 commit into
Open
feat(portfolio): add getPositionLots endpoint for per-position tax lots#9samyk wants to merge 1 commit into
samyk wants to merge 1 commit into
Conversation
The View Portfolio response never embeds <PositionLot> data, even with
lotsRequired=true — E*TRADE only populates each position's lotsDetails
link and serves the actual lots from a separate per-position endpoint.
That endpoint (GET /accounts/{accountIdKey}/portfolio/{positionId}) was
missing from the OpenAPI spec, so no MCP tool was generated for it and
tax-lot data (cost basis, acquisition date, term, remaining qty) was
unreachable through the server.
Add the operation to etrade-api.yaml as operationId `getPositionLots`,
returning the existing PortfolioResponse schema (which already carries
the PositionLot array). This exposes a getPositionLots MCP tool, enabling
lot-level cost-basis and tax analysis (e.g. lowest-tax-lot selection).
Spec-only change; reuses existing PositionLot/PortfolioResponse schemas.
Verified against a live account: positions return multiple lots with
correct price, termCode, remainingQty, and acquiredDate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The View Portfolio response never embeds data, even with lotsRequired=true — E*TRADE only populates each position's lotsDetails link and serves the actual lots from a separate per-position endpoint. That endpoint (GET /accounts/{accountIdKey}/portfolio/{positionId}) was missing from the OpenAPI spec, so no MCP tool was generated for it and tax-lot data (cost basis, acquisition date, term, remaining qty) was unreachable through the server.
Add the operation to etrade-api.yaml as operationId
getPositionLots, returning the existing PortfolioResponse schema (which already carries the PositionLot array). This exposes a getPositionLots MCP tool, enabling lot-level cost-basis and tax analysis (e.g. lowest-tax-lot selection). Spec-only change; reuses existing PositionLot/PortfolioResponse schemas. Verified against a live account: positions return multiple lots with correct price, termCode, remainingQty, and acquiredDate.