-
Notifications
You must be signed in to change notification settings - Fork 9
change copy prompt button hover to underline #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
f5e30a8
6e3f46a
41d71e8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -178,3 +178,24 @@ table tbody td:first-child { | |
| width: 100%; | ||
| } | ||
| } | ||
|
|
||
| /* static placeholder for copy prompt button — visible before React hydrates */ | ||
| .copy-prompt-placeholder { | ||
| display: inline-flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| gap: 0.5rem; | ||
| width: 100%; | ||
| max-width: 352px; | ||
| height: 56px; | ||
| padding: 0 32px; | ||
| font-size: 0.9375rem; | ||
| font-weight: 500; | ||
| letter-spacing: 0.01em; | ||
| color: #fff; | ||
| background-color: #111; | ||
| border: 1px solid rgba(255, 255, 255, 0.08); | ||
| cursor: pointer; | ||
| font-family: inherit; | ||
| box-sizing: border-box; | ||
| } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Placeholder width doesn't match button's actual rendered widthMedium Severity The new Additional Locations (1)Reviewed by Cursor Bugbot for commit 6e3f46a. Configure here. |
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transition on non-animatable text-decoration-line is ineffective
Low Severity
The
transition: 'text-decoration 0.15s ease'declaration is dead code. CSS cannot transitiontext-decoration-line(which is what changes betweennoneandunderline). Onlytext-decoration-colorandtext-decoration-thicknessare animatable sub-properties. The underline will still appear and disappear on hover, but it snaps instantly with no smooth transition, making this line misleading.Reviewed by Cursor Bugbot for commit f5e30a8. Configure here.