libbpf: fix possible use-after-free for externs #9163
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: e30329b |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
a994d4a to
e7d5deb
Compare
|
Upstream branch: 99fe8af |
The `name` field in `obj->externs` points into the BTF data at load time. However, some functions may invalidate this after loading (e.g. `bpf_map__set_value_size`), which results in pointers into freed memory and undefined behavior. The simplest solution is to simply `strdup` these strings, similar to the `essent_name`, and free them at the same time. Signed-off-by: Adin Scannell <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/974002=>bpf-next
branch
from
d82e50e to
34748f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: libbpf: fix possible use-after-free for externs
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=974002