Don't let unit test modify the source folder.#22194
Merged
hertschuh merged 1 commit intokeras-team:masterfrom Feb 17, 2026
Merged
Don't let unit test modify the source folder.#22194hertschuh merged 1 commit intokeras-team:masterfrom
hertschuh merged 1 commit intokeras-team:masterfrom
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Changed some unit tests to use a temporary folder instead of the current one. Also fixed `file_utils.filter_safe_zipinfos` and `filter_safe_tarinfos` to resolve links within the context of the destination folder instead of hardcoding `"."` as the destination path.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22194 +/- ##
==========================================
- Coverage 82.77% 82.77% -0.01%
==========================================
Files 593 593
Lines 63867 63866 -1
Branches 10040 10040
==========================================
- Hits 52866 52865 -1
Misses 8424 8424
Partials 2577 2577
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
divyashreepathihalli
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required changing some tests to use a temporary folder instead of the current one.
Changed some unit tests to use a temporary folder instead of the current one. This uses
self.get_temp_dir(), which auto cleans up and makes the tests easier.Also fixed
file_utils.filter_safe_zipinfosandfilter_safe_tarinfosto resolve links within the context of the destination folder instead of hardcoding"."as the destination path.